[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-5.2? 1/2] tests/qtest: variable defined by g_autofree nee
From: |
Peter Maydell |
Subject: |
Re: [PATCH-for-5.2? 1/2] tests/qtest: variable defined by g_autofree need to be initialized |
Date: |
Thu, 19 Nov 2020 08:26:17 +0000 |
On Wed, 18 Nov 2020 at 11:57, Chen Qun <kuhn.chenqun@huawei.com> wrote:
>
> According to the glib function requirements, we need initialise
> the variable. Otherwise there will be compilation warnings:
>
> glib-autocleanups.h:28:3: warning: ‘full_name’ may be
> used uninitialized in this function [-Wmaybe-uninitialized]
> 28 | g_free (*pp);
> | ^~~~~~~~~~~~
>
> static void tim_add_test(const char *name, const TestData *td, GTestDataFunc
> fn)
> {
> - g_autofree char *full_name;
> -
> - full_name = g_strdup_printf("npcm7xx_timer/tim[%d]/timer[%d]/%s",
> - tim_index(td->tim), timer_index(td->timer),
> - name);
> + g_autofree char *full_name = g_strdup_printf(
> + "npcm7xx_timer/tim[%d]/timer[%d]/%s", tim_index(td->tim),
> + timer_index(td->timer), name);
Which compiler is so unintelligent that it cannot see that
a declaration immediately followed by an assignment must
always initialize the variable ???
thanks
-- PMM
[PATCH-for-5.2? 2/2] tests/qtest: fix memleak in npcm7xx_watchdog_timer-test, Chen Qun, 2020/11/18