[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category |
Date: |
Tue, 17 Nov 2020 06:41:16 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Peter Maydell <peter.maydell@linaro.org> writes:
> On Mon, 16 Nov 2020 at 17:09, Markus Armbruster <armbru@redhat.com> wrote:
>> But TYPE_CPRMAN_PLL is *not* a descendant of TYPE_SYS_BUS_DEVICE, it's a
>> bus-less device:
>>
>> static const TypeInfo cprman_pll_info = {
>> .name = TYPE_CPRMAN_PLL,
>> ---> .parent = TYPE_DEVICE,
>> .instance_size = sizeof(CprmanPllState),
>> .class_init = pll_class_init,
>> .instance_init = pll_init,
>> };
>
> I'm really dubious of devices that directly inherit from
> TYPE_DEVICE, because their reset method won't be automatically
> called. In this case it looks like the TYPE_BCM2835_CPRMAN
> device's reset method manually calls reset on these devices,
> though, so it isn't actually buggy, just confusing.
I guess this is a trap for unwary implementers, aggravated by our usual
dearth of qdev documentation. I can see ~100 .parent = TYPE_DEVICE
lines. Checking them all manually won't be fun. Any automation ideas?
The concept "bus-less device" is sane. We used not to have it, and the
resulting need for pseudo-busses was annoying enough to make us add
bus-less devices.
- [PATCH 12/13] SPI flash devices: put them into the 'storage' category, (continued)
- [PATCH 12/13] SPI flash devices: put them into the 'storage' category, Gan Qixin, 2020/11/16
- [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category, Gan Qixin, 2020/11/16
- Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category, Philippe Mathieu-Daudé, 2020/11/16
- Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category, Thomas Huth, 2020/11/16
- Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category, Markus Armbruster, 2020/11/16
- Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category, Peter Maydell, 2020/11/16
- Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category,
Markus Armbruster <=
- Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category, Peter Maydell, 2020/11/17
- Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category, Thomas Huth, 2020/11/17
- Re: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category, Markus Armbruster, 2020/11/18
- Should bus-less devices default to .user_creatable = false? (was: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category), Markus Armbruster, 2020/11/18
- Re: Should bus-less devices default to .user_creatable = false? (was: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category), Thomas Huth, 2020/11/18
- RE: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category, ganqixin, 2020/11/17