[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] bsd-user: space required after semicolon
From: |
shiliyang |
Subject: |
Re: [PATCH 1/4] bsd-user: space required after semicolon |
Date: |
Thu, 5 Nov 2020 15:21:20 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 |
On 2020/11/4 19:13, Philippe Mathieu-Daudé wrote:
> On 11/4/20 12:08 PM, Thomas Huth wrote:
>> On 04/11/2020 11.20, shiliyang wrote:
>>> This patch fixes error style problems found by checkpatch.pl:
>>> ERROR: space required after that ';'
>>>
>>> Signed-off-by: Liyang Shi <shiliyang@huawei.com>
>>>
>>> ---
>>> bsd-user/elfload.c | 2 +-
>>> bsd-user/syscall.c | 4 ++--
>>> 2 files changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c
>>> index 9f4210af9a..25e625d86b 100644
>>> --- a/bsd-user/elfload.c
>>> +++ b/bsd-user/elfload.c
>>> @@ -1227,7 +1227,7 @@ int load_elf_binary(struct linux_binprm *bprm, struct
>>> target_pt_regs *regs,
>>> end_data = 0;
>>> interp_ex.a_info = 0;
>>>
>>> - for(i=0;i < elf_ex.e_phnum; i++) {
>>> + for(i=0; i < elf_ex.e_phnum; i++) {
>>
>> While you're at it, please also add white spaces around the "=" in that line.
>
Yes, thanks for your review, I will fix it.
> IOW please run checkpatch after fixing a checkpatch issue ;)
>
Thanks for your advise, I missed this operation. I will fix other checkpatch
issues first then send new patch.
> .
>
Thanks.