[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 7/8] ppc: Add a missing break for PPC6xx_INPUT_TBEN
From: |
Thomas Huth |
Subject: |
Re: [PATCH v2 7/8] ppc: Add a missing break for PPC6xx_INPUT_TBEN |
Date: |
Fri, 30 Oct 2020 16:41:45 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 30/10/2020 01.40, Chen Qun wrote:
> When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning:
> hw/ppc/ppc.c: In function ‘ppc6xx_set_irq’:
> hw/ppc/ppc.c:118:16: warning: this statement may fall through
> [-Wimplicit-fallthrough=]
> 118 | if (level) {
> | ^
> hw/ppc/ppc.c:123:9: note: here
> 123 | case PPC6xx_INPUT_INT:
> | ^~~~
>
> According to the discussion, a break statement needs to be added here.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> ---
> v1->v2: Add a "break" statement here instead of /* fall through */ comments
> (Base on Thomas's and David review).
>
> Cc: Thomas Huth <thuth@redhat.com>
> Cc: David Gibson <david@gibson.dropbear.id.au>
> ---
> hw/ppc/ppc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c
> index 4a11fb1640..1b98272076 100644
> --- a/hw/ppc/ppc.c
> +++ b/hw/ppc/ppc.c
> @@ -120,6 +120,7 @@ static void ppc6xx_set_irq(void *opaque, int pin, int
> level)
> } else {
> cpu_ppc_tb_stop(env);
> }
> + break;
> case PPC6xx_INPUT_INT:
> /* Level sensitive - active high */
> LOG_IRQ("%s: set the external IRQ state to %d\n",
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
- Re: [PATCH v2 3/8] accel/tcg/user-exec: silence the compiler warnings, (continued)
- [PATCH v2 1/8] target/i386: silence the compiler warnings in gen_shiftd_rm_T1, Chen Qun, 2020/10/29
- [PATCH v2 8/8] target/ppc: replaced the TODO with LOG_UNIMP and add break for silence warnings, Chen Qun, 2020/10/29
- [PATCH v2 2/8] hw/intc/arm_gicv3_kvm: silence the compiler warnings, Chen Qun, 2020/10/29
- [PATCH v2 5/8] target/sparc/translate: silence the compiler warnings, Chen Qun, 2020/10/29
- [PATCH v2 7/8] ppc: Add a missing break for PPC6xx_INPUT_TBEN, Chen Qun, 2020/10/29
- [PATCH v2 6/8] target/sparc/win_helper: silence the compiler warnings, Chen Qun, 2020/10/29