[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 2/7] hw/char/serial: Replace commented DPRINTF() by trace even
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 2/7] hw/char/serial: Replace commented DPRINTF() by trace event |
Date: |
Sat, 12 Sep 2020 13:40:35 +0200 |
Convert the old debug PRINTF() call to display the UART
baudrate to a trace event.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/char/serial.c | 4 +---
hw/char/trace-events | 1 +
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/char/serial.c b/hw/char/serial.c
index a855ef66ea2..fb41337b661 100644
--- a/hw/char/serial.c
+++ b/hw/char/serial.c
@@ -187,9 +187,7 @@ static void serial_update_parameters(SerialState *s)
ssp.stop_bits = stop_bits;
s->char_transmit_time = (NANOSECONDS_PER_SECOND / speed) * frame_size;
qemu_chr_fe_ioctl(&s->chr, CHR_IOCTL_SERIAL_SET_PARAMS, &ssp);
-
- DPRINTF("speed=%.2f parity=%c data=%d stop=%d\n",
- speed, parity, data_bits, stop_bits);
+ trace_serial_update_parameters(speed, parity, data_bits, stop_bits);
}
static void serial_update_msl(SerialState *s)
diff --git a/hw/char/trace-events b/hw/char/trace-events
index 2442a9f7d5f..17304bef26d 100644
--- a/hw/char/trace-events
+++ b/hw/char/trace-events
@@ -7,6 +7,7 @@ parallel_ioport_write(const char *desc, uint16_t addr, uint8_t
value) "write [%s
# serial.c
serial_ioport_read(uint16_t addr, uint8_t value) "read addr 0x%02x val 0x%02x"
serial_ioport_write(uint16_t addr, uint8_t value) "write addr 0x%02x val
0x%02x"
+serial_update_parameters(uint64_t baudrate, char parity, int data_bits, int
stop_bits) "baudrate=%"PRIu64" parity='%c' data=%d stop=%d"
# virtio-serial-bus.c
virtio_serial_send_control_event(unsigned int port, uint16_t event, uint16_t
value) "port %u, event %u, value %u"
--
2.26.2
- [PATCH v2 0/7] hw/char/serial: Housekeeping, Philippe Mathieu-Daudé, 2020/09/12
- [PATCH v2 2/7] hw/char/serial: Replace commented DPRINTF() by trace event,
Philippe Mathieu-Daudé <=
- [PATCH v2 1/7] hw/char/serial: Assert serial_ioport_read/write offset fits 8 bytes, Philippe Mathieu-Daudé, 2020/09/12
- [PATCH v2 3/7] hw/char/serial: Remove old DEBUG_SERIAL commented code, Philippe Mathieu-Daudé, 2020/09/12
- [PATCH v2 4/7] hw/char/serial: Rename I/O read/write trace events, Philippe Mathieu-Daudé, 2020/09/12
- [PATCH v2 5/7] hw/char/serial: Make 'wakeup' property boolean, Philippe Mathieu-Daudé, 2020/09/12
- [PATCH v2 6/7] hw/char/serial: Alias QDEV properties from generic serial object, Philippe Mathieu-Daudé, 2020/09/12
- [PATCH v2 7/7] hw/char/serial: Let SerialState have an 'id' field, Philippe Mathieu-Daudé, 2020/09/12
- Re: [PATCH v2 0/7] hw/char/serial: Housekeeping, no-reply, 2020/09/12
- Re: [PATCH v2 0/7] hw/char/serial: Housekeeping, no-reply, 2020/09/12