[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 05/18] hw/gpio/max7310: Replace disabled printf() by qemu_log_mask
From: |
Laurent Vivier |
Subject: |
[PULL 05/18] hw/gpio/max7310: Replace disabled printf() by qemu_log_mask(UNIMP) |
Date: |
Fri, 11 Sep 2020 21:33:17 +0200 |
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Replace disabled printf() by qemu_log_mask(UNIMP).
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20200901104234.92159-3-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/gpio/max7310.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/hw/gpio/max7310.c b/hw/gpio/max7310.c
index 4f78774dc8f2..3e298c2d349c 100644
--- a/hw/gpio/max7310.c
+++ b/hw/gpio/max7310.c
@@ -13,6 +13,7 @@
#include "hw/hw.h"
#include "hw/irq.h"
#include "migration/vmstate.h"
+#include "qemu/log.h"
#include "qemu/module.h"
#define TYPE_MAX7310 "max7310"
@@ -68,9 +69,8 @@ static uint8_t max7310_rx(I2CSlave *i2c)
return 0xff;
default:
-#ifdef VERBOSE
- printf("%s: unknown register %02x\n", __func__, s->command);
-#endif
+ qemu_log_mask(LOG_UNIMP, "%s: Unsupported register 0x02%" PRIx8 "\n",
+ __func__, s->command);
break;
}
return 0xff;
@@ -122,9 +122,8 @@ static int max7310_tx(I2CSlave *i2c, uint8_t data)
case 0x00: /* Input port - ignore writes */
break;
default:
-#ifdef VERBOSE
- printf("%s: unknown register %02x\n", __func__, s->command);
-#endif
+ qemu_log_mask(LOG_UNIMP, "%s: Unsupported register 0x02%" PRIx8 "\n",
+ __func__, s->command);
return 1;
}
--
2.26.2
- [PULL 00/18] Trivial branch for 5.2 patches, Laurent Vivier, 2020/09/11
- [PULL 02/18] hw/isa/isa-bus: Replace hw_error() by assert(), Laurent Vivier, 2020/09/11
- [PULL 04/18] hw/gpio/omap_gpio: Replace fprintf() by qemu_log_mask(GUEST_ERROR), Laurent Vivier, 2020/09/11
- [PULL 03/18] hw/acpi/tco: Remove unused definitions, Laurent Vivier, 2020/09/11
- [PULL 05/18] hw/gpio/max7310: Replace disabled printf() by qemu_log_mask(UNIMP),
Laurent Vivier <=
- [PULL 06/18] Makefile: Drop extra phony cscope, Laurent Vivier, 2020/09/11
- [PULL 01/18] hw/mips/fuloong2e: Convert pointless error message to an assert(), Laurent Vivier, 2020/09/11
- [PULL 08/18] hw/net/e1000e: Remove overwritten read handler for STATUS register, Laurent Vivier, 2020/09/11
- [PULL 07/18] Makefile: Skip the meson subdir in cscope/TAGS/ctags, Laurent Vivier, 2020/09/11
- [PULL 09/18] hw/net/e1000e: Remove duplicated write handler for FLSWDATA register, Laurent Vivier, 2020/09/11
- [PULL 11/18] kconfig: fix comment referring to old Makefiles, Laurent Vivier, 2020/09/11
- [PULL 14/18] target/i386/kvm: Rename host_tsx_blacklisted() as host_tsx_broken(), Laurent Vivier, 2020/09/11
- [PULL 12/18] hw: hyperv: vmbus: Fix 32bit compilation, Laurent Vivier, 2020/09/11
- [PULL 15/18] hw/arm/pxa2xx: Add missing fallthrough comment, Laurent Vivier, 2020/09/11
- [PULL 18/18] target/i386/kvm: Add missing fallthrough comment, Laurent Vivier, 2020/09/11