[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/5] hw/mips/fuloong2e: Convert pointless error message to an
From: |
Richard Henderson |
Subject: |
Re: [PATCH 2/5] hw/mips/fuloong2e: Convert pointless error message to an assert() |
Date: |
Tue, 1 Sep 2020 10:49:50 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 9/1/20 3:40 AM, Philippe Mathieu-Daudé wrote:
> Displaying "vt82c686b_init error" doesn't give any hint about why
> this call failed. As this message targets developers and not users,
> replace the pointless error message by a call to assert() which
> will provide more useful information.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/mips/fuloong2e.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
- [PATCH 0/5] hw: Replace some impossible checks by assertions, Philippe Mathieu-Daudé, 2020/09/01
- [PATCH 1/5] hw/gpio/max7310: Remove impossible check, Philippe Mathieu-Daudé, 2020/09/01
- [PATCH 2/5] hw/mips/fuloong2e: Convert pointless error message to an assert(), Philippe Mathieu-Daudé, 2020/09/01
- [PATCH 3/5] hw/ppc/ppc4xx_pci: Use ARRAY_SIZE() instead of magic value, Philippe Mathieu-Daudé, 2020/09/01
- [PATCH 4/5] hw/ppc/ppc4xx_pci: Replace pointless warning by assert(), Philippe Mathieu-Daudé, 2020/09/01
- [PATCH 5/5] hw/isa/isa-bus: Replace hw_error() by assert(), Philippe Mathieu-Daudé, 2020/09/01