[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 33/44] hw/arm/virt-acpi-build:Remove dead assignment in build_madt
From: |
Laurent Vivier |
Subject: |
[PULL 33/44] hw/arm/virt-acpi-build:Remove dead assignment in build_madt() |
Date: |
Tue, 1 Sep 2020 16:09:43 +0200 |
From: Chen Qun <kuhn.chenqun@huawei.com>
Clang static code analyzer show warning:
hw/arm/virt-acpi-build.c:641:5: warning: Value stored to 'madt' is never read
madt = acpi_data_push(table_data, sizeof *madt);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <20200827110311.164316-2-kuhn.chenqun@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/arm/virt-acpi-build.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 0a482ff6f734..9efd7a388150 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -633,12 +633,11 @@ build_madt(GArray *table_data, BIOSLinker *linker,
VirtMachineState *vms)
int madt_start = table_data->len;
const MemMapEntry *memmap = vms->memmap;
const int *irqmap = vms->irqmap;
- AcpiMultipleApicTable *madt;
AcpiMadtGenericDistributor *gicd;
AcpiMadtGenericMsiFrame *gic_msi;
int i;
- madt = acpi_data_push(table_data, sizeof *madt);
+ acpi_data_push(table_data, sizeof(AcpiMultipleApicTable));
gicd = acpi_data_push(table_data, sizeof *gicd);
gicd->type = ACPI_APIC_GENERIC_DISTRIBUTOR;
--
2.26.2
- [PULL 21/44] util/qemu-timer: Fix typo in description, (continued)
- [PULL 21/44] util/qemu-timer: Fix typo in description, Laurent Vivier, 2020/09/01
- [PULL 32/44] linux-user: Add strace support for printing OFD fcntl operations, Laurent Vivier, 2020/09/01
- [PULL 26/44] hw/ide/ahci: Replace magic '512' value by BDRV_SECTOR_SIZE, Laurent Vivier, 2020/09/01
- [PULL 09/44] target/cris: Remove superfluous breaks, Laurent Vivier, 2020/09/01
- [PULL 27/44] hw/ide/atapi: Replace magic '512' value by BDRV_SECTOR_SIZE, Laurent Vivier, 2020/09/01
- [PULL 28/44] hw/ide/pci: Replace magic '512' value by BDRV_SECTOR_SIZE, Laurent Vivier, 2020/09/01
- [PULL 25/44] hw/ide/core: Trivial typo fix, Laurent Vivier, 2020/09/01
- [PULL 29/44] hw/scsi/scsi-disk: Replace magic '512' value by BDRV_SECTOR_SIZE, Laurent Vivier, 2020/09/01
- [PULL 35/44] target/arm/translate-a64:Remove dead assignment in handle_scalar_simd_shli(), Laurent Vivier, 2020/09/01
- [PULL 36/44] target/arm/translate-a64:Remove redundant statement in disas_simd_two_reg_misc_fp16(), Laurent Vivier, 2020/09/01
- [PULL 33/44] hw/arm/virt-acpi-build:Remove dead assignment in build_madt(),
Laurent Vivier <=
- [PULL 39/44] vfio/platform: Remove dead assignment in vfio_intp_interrupt(), Laurent Vivier, 2020/09/01
- [PULL 40/44] usb/bus: Remove dead assignment in usb_get_fw_dev_path(), Laurent Vivier, 2020/09/01
- [PULL 38/44] hw/net/virtio-net:Remove redundant statement in virtio_net_rsc_tcp_ctrl_check(), Laurent Vivier, 2020/09/01
- [PULL 37/44] hw/virtio/vhost-user:Remove dead assignment in scrub_shadow_regions(), Laurent Vivier, 2020/09/01
- [PULL 22/44] util/vfio-helpers: Fix typo in description, Laurent Vivier, 2020/09/01
- [PULL 30/44] hw/net/xilinx_axienet: Remove unused code, Laurent Vivier, 2020/09/01
- [PULL 31/44] util/vfio-helpers: Unify trace-events size format, Laurent Vivier, 2020/09/01
- [PULL 34/44] hw/arm/omap1:Remove redundant statement in omap_clkdsp_read(), Laurent Vivier, 2020/09/01
- [PULL 43/44] main-loop: Fix comment, Laurent Vivier, 2020/09/01
- [PULL 44/44] docs/system: Fix grammar in documentation, Laurent Vivier, 2020/09/01