[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 02/10] hw/arm/omap1:Remove redundant statement in omap_clk
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v3 02/10] hw/arm/omap1:Remove redundant statement in omap_clkdsp_read() |
Date: |
Tue, 1 Sep 2020 11:53:53 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
Le 27/08/2020 à 13:03, Chen Qun a écrit :
> Clang static code analyzer show warning:
> hw/arm/omap1.c:1760:15: warning: Value stored to 'cpu' during its
> initialization is never read
> CPUState *cpu = CPU(s->cpu);
> ^~~ ~~~~~~~~~~~
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Li Qiang <liq3ea@gmail.com>
> ---
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: qemu-arm@nongnu.org
> ---
> hw/arm/omap1.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/arm/omap1.c b/hw/arm/omap1.c
> index 6ba0df6b6d..02c0f66431 100644
> --- a/hw/arm/omap1.c
> +++ b/hw/arm/omap1.c
> @@ -1774,7 +1774,6 @@ static uint64_t omap_clkdsp_read(void *opaque, hwaddr
> addr,
> return s->clkm.dsp_rstct2;
>
> case 0x18: /* DSP_SYSST */
> - cpu = CPU(s->cpu);
> return (s->clkm.clocking_scheme << 11) | s->clkm.cold_start |
> (cpu->halted << 6); /* Quite useless... */
> }
>
Applied to my trivial-patches branch.
Thanks,
Laurent
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v3 02/10] hw/arm/omap1:Remove redundant statement in omap_clkdsp_read(),
Laurent Vivier <=