[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/12] scsi: Remove superfluous breaks
From: |
Laurent Vivier |
Subject: |
Re: [PATCH 04/12] scsi: Remove superfluous breaks |
Date: |
Tue, 1 Sep 2020 08:35:16 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
Le 13/07/2020 à 11:33, Thomas Huth a écrit :
> On 13/07/2020 11.04, Yi Wang wrote:
>> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>>
>> Remove superfluous breaks, as there is a "return" before them.
>>
>> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
>> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> scsi/utils.c | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/scsi/utils.c b/scsi/utils.c
>> index c50e81f..b37c283 100644
>> --- a/scsi/utils.c
>> +++ b/scsi/utils.c
>> @@ -32,17 +32,13 @@ uint32_t scsi_cdb_xfer(uint8_t *buf)
>> switch (buf[0] >> 5) {
>> case 0:
>> return buf[4];
>> - break;
>> case 1:
>> case 2:
>> return lduw_be_p(&buf[7]);
>> - break;
>> case 4:
>> return ldl_be_p(&buf[10]) & 0xffffffffULL;
>> - break;
>> case 5:
>> return ldl_be_p(&buf[6]) & 0xffffffffULL;
>> - break;
>> default:
>> return -1;
>> }
>>
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH 04/12] scsi: Remove superfluous breaks,
Laurent Vivier <=