Re: [PATCH v5] qapi/opts-visitor: Added missing fallthrough annotations

[Rohit Shinde]

Hey Markus,

Thanks for the clarification! No, I do not have patches for the same. I was browsing through the bite sized tasks page and that did not mention these details. I will keep this in mind however. For now, I will leave this task and I might return to it at a later time.

Thanks,

Rohit.

On Wed, Aug 26, 2020 at 11:10 PM Markus Armbruster <armbru@redhat.com> wrote:

Rohit Shinde <rohit.shinde12194@gmail.com> writes:

> I am just compiling with cflag set to -Wimplicit-fallthrough. I am using
> gcc.

-Wimplicit-fallthrough is the same as -Wimplicit-fallthrough=3.  Our
-code is not prepared for that.  What should work is
--Wimplicit-fallthrough=2.

If you have patches to make the entire tree compile with
-Wimplicit-fallthrough=3, we can talk.  You'd have to test them on all
supported hosts, and with a sufficient range of configurations to ensure
they are not breaking builds.