qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] semihosting: remove the pthread include which seems unused


From: Alex Bennée
Subject: Re: [PATCH] semihosting: remove the pthread include which seems unused
Date: Mon, 01 Jun 2020 11:29:26 +0100
User-agent: mu4e 1.5.1; emacs 28.0.50

Fred Konrad <konrad@adacore.com> writes:

> Le 5/18/20 à 3:50 PM, Philippe Mathieu-Daudé a écrit :
>> On 5/18/20 3:02 PM, konrad@adacore.com wrote:
>>> From: KONRAD Frederic <frederic.konrad@adacore.com>
>>>
>>> This have been introduced by:
>>>    8de702cb677c8381fb702cae252d6b69aa4c653b
>>>
>>> It doesn't seem to be used so remove it.
>>>
>>> Signed-off-by: KONRAD Frederic <frederic.konrad@adacore.com>
>>> ---
>>>   hw/semihosting/console.c | 1 -
>>>   1 file changed, 1 deletion(-)
>>>
>>> diff --git a/hw/semihosting/console.c b/hw/semihosting/console.c
>>> index 6346bd7..22e7827 100644
>>> --- a/hw/semihosting/console.c
>>> +++ b/hw/semihosting/console.c
>>> @@ -23,7 +23,6 @@
>>>   #include "exec/exec-all.h"
>>>   #include "qemu/log.h"
>>>   #include "chardev/char.h"
>>> -#include <pthread.h>
>>>   #include "chardev/char-fe.h"
>>>   #include "sysemu/sysemu.h"
>>>   #include "qemu/main-loop.h"
>>>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> 
>
> Thanks for the review, Philippe.  Can this go through qemu-trivial?

Sure:

Acked-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]