[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 14/18] hw/pci-host/piix: Include "qemu/range.h"
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 14/18] hw/pci-host/piix: Include "qemu/range.h" |
Date: |
Fri, 28 Feb 2020 12:46:45 +0100 |
hw/pci-host/piix.c calls various functions from the Range API.
Include "qemu/range.h" which declares them.
This fixes (when modifying unrelated headers):
hw/pci-host/i440fx.c:54:11: error: field has incomplete type 'Range' (aka
'struct Range')
Range pci_hole;
^
include/qemu/typedefs.h:116:16: note: forward declaration of 'struct Range'
typedef struct Range Range;
^
hw/pci-host/i440fx.c:126:9: error: implicit declaration of function
'ranges_overlap' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
if (ranges_overlap(address, len, I440FX_PAM, I440FX_PAM_SIZE) ||
^
hw/pci-host/i440fx.c:126:9: error: this function declaration is not a
prototype [-Werror,-Wstrict-prototypes]
hw/pci-host/i440fx.c:127:9: error: implicit declaration of function
'range_covers_byte' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
range_covers_byte(address, len, I440FX_SMRAM)) {
^
hw/pci-host/i440fx.c:127:9: error: this function declaration is not a
prototype [-Werror,-Wstrict-prototypes]
hw/pci-host/i440fx.c:189:13: error: implicit declaration of function
'range_is_empty' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
val64 = range_is_empty(&s->pci_hole) ? 0 : range_lob(&s->pci_hole);
^
Acked-by: John Snow <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/pci-host/i440fx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/pci-host/i440fx.c b/hw/pci-host/i440fx.c
index 11050a0f8b..d980c97049 100644
--- a/hw/pci-host/i440fx.c
+++ b/hw/pci-host/i440fx.c
@@ -23,6 +23,7 @@
*/
#include "qemu/osdep.h"
+#include "qemu/range.h"
#include "hw/i386/pc.h"
#include "hw/pci/pci.h"
#include "hw/pci/pci_host.h"
--
2.21.1
- Re: [PATCH v2 05/18] hw/usb/dev-storage: Remove unused "ui/console.h" header, (continued)
- [PATCH v2 06/18] hw/i386/intel_iommu: Remove unused includes, Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 07/18] hw/alpha/alpha_sys: Remove unused "hw/ide.h" header, Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 08/18] hw/alpha/dp264: Include "net/net.h", Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 11/18] hw/timer/hpet: Include "exec/address-spaces.h", Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 09/18] hw/hppa/machine: Include "net/net.h", Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 10/18] hw/acpi/cpu_hotplug: Include "hw/pci/pci.h", Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 12/18] hw/pci-host/q35: Include "qemu/range.h", Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 13/18] hw/i2c/smbus_ich9: Include "qemu/range.h", Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 15/18] hw/acpi: Include "hw/mem/nvdimm.h", Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 14/18] hw/pci-host/piix: Include "qemu/range.h",
Philippe Mathieu-Daudé <=
- [PATCH v2 16/18] hw/i386: Include "hw/mem/nvdimm.h", Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 17/18] hw/pci-host/q35: Remove unused includes, Philippe Mathieu-Daudé, 2020/02/28
- [PATCH v2 18/18] hw/i386/pc: Clean up includes, Philippe Mathieu-Daudé, 2020/02/28
- Re: [PATCH v2 00/18] hw: Clean up hw/i386 headers (and few alpha/hppa), Richard Henderson, 2020/02/29