[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] test-vmstate: Fix memleaks in test_load_qlist
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v2] test-vmstate: Fix memleaks in test_load_qlist |
Date: |
Thu, 20 Feb 2020 15:06:17 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
Le 20/02/2020 à 14:41, address@hidden a écrit :
> From: Chen Qun <address@hidden>
>
> There is memleak in test_load_qlist().It's not a big deal,
> but test-vmstate will fail if sanitizers is enabled.
>
> In addition, "ret" is written twice with the same value
> in test_gtree_load_iommu().
>
> Reported-by: Euler Robot <address@hidden>
> Signed-off-by: Chen Qun <address@hidden>
> ---
> tests/test-vmstate.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
> index cea363dd69..f7b3868881 100644
> --- a/tests/test-vmstate.c
> +++ b/tests/test-vmstate.c
> @@ -1241,7 +1241,6 @@ static void test_gtree_load_iommu(void)
> TestGTreeIOMMU *orig_iommu = create_iommu();
> QEMUFile *fsave, *fload;
> char eof;
> - int ret;
>
> fsave = open_test_file(true);
> qemu_put_buffer(fsave, iommu_dump, sizeof(iommu_dump));
> @@ -1250,10 +1249,8 @@ static void test_gtree_load_iommu(void)
>
> fload = open_test_file(false);
> vmstate_load_state(fload, &vmstate_iommu, dest_iommu, 1);
> - ret = qemu_file_get_error(fload);
> eof = qemu_get_byte(fload);
> - ret = qemu_file_get_error(fload);
> - g_assert(!ret);
> + g_assert(!qemu_file_get_error(fload));/
> g_assert_cmpint(orig_iommu->id, ==, dest_iommu->id);
> g_assert_cmpint(eof, ==, QEMU_VM_EOF);
>
> @@ -1395,6 +1392,7 @@ static void test_load_qlist(void)
> compare_containers(orig_container, dest_container);
> free_container(orig_container);
> free_container(dest_container);
> + qemu_fclose(fload);
> }
>
> typedef struct TmpTestStruct {
>
Reviewed-by: Laurent Vivier <address@hidden>