[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] hw/nios2:fix leak of fdevice tree blob
From: |
Laurent Vivier |
Subject: |
Re: [PATCH 1/3] hw/nios2:fix leak of fdevice tree blob |
Date: |
Wed, 19 Feb 2020 10:29:19 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
Le 18/02/2020 à 10:11, address@hidden a écrit :
> From: Chen Qun <address@hidden>
>
> The device tree blob returned by load_device_tree is malloced.
> We should free it after cpu_physical_memory_write().
>
> Reported-by: Euler Robot <address@hidden>
> Signed-off-by: Chen Qun <address@hidden>
> ---
> hw/nios2/boot.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/nios2/boot.c b/hw/nios2/boot.c
> index 46b8349876..88224aa84c 100644
> --- a/hw/nios2/boot.c
> +++ b/hw/nios2/boot.c
> @@ -109,6 +109,7 @@ static int nios2_load_dtb(struct nios2_boot_info bi,
> const uint32_t ramsize,
> }
>
> cpu_physical_memory_write(bi.fdt, fdt, fdt_size);
> + g_free(fdt);
> return fdt_size;
> }
>
>
Reviewed-by: Laurent Vivier <address@hidden>