[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/net/rocker: Report unimplemented feature with qemu_log_ma
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH] hw/net/rocker: Report unimplemented feature with qemu_log_mask(UNIMP) |
Date: |
Tue, 18 Feb 2020 10:56:18 +0000 |
On Mon, Feb 17, 2020 at 11:16:37AM +0100, Philippe Mathieu-Daudé wrote:
> Fix warnings reported by Clang static code analyzer:
>
> CC hw/net/rocker/rocker.o
> hw/net/rocker/rocker.c:213:9: warning: Value stored to 'tx_tso_mss' is
> never read
> tx_tso_mss = rocker_tlv_get_le16(tlvs[ROCKER_TLV_TX_TSO_MSS]);
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> hw/net/rocker/rocker.c:217:9: warning: Value stored to 'tx_tso_hdr_len' is
> never read
> tx_tso_hdr_len =
> rocker_tlv_get_le16(tlvs[ROCKER_TLV_TX_TSO_HDR_LEN]);
> ^
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> hw/net/rocker/rocker.c:255:9: warning: Value stored to 'tx_l3_csum_off' is
> never read
> tx_l3_csum_off += tx_tso_mss = tx_tso_hdr_len = 0;
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: dc488f888
> Reported-by: Clang Static Analyzer
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/net/rocker/rocker.c | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature