[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH-for-4.1? 1/7] json: Move switch '
From: |
Eric Blake |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH-for-4.1? 1/7] json: Move switch 'fall through' comment to correct place |
Date: |
Fri, 19 Jul 2019 10:31:39 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 7/19/19 8:14 AM, Philippe Mathieu-Daudé wrote:
> Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=2:
>
> qobject/json-parser.c: In function ‘parse_literal’:
> qobject/json-parser.c:492:24: error: this statement may fall through
> [-Werror=implicit-fallthrough=]
> 492 | case JSON_INTEGER: {
> | ^
> qobject/json-parser.c:524:5: note: here
> 524 | case JSON_FLOAT:
> | ^~~~
>
> Correctly place the 'fall through' comment.
>
> Reported-by: Stefan Weil <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> qobject/json-parser.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature