Re: [Qemu-trivial] [Qemu-devel] [PULL 0/3] Trivial branch patches

[Philippe Mathieu-Daudé]

On 7/2/19 8:05 PM, Laurent Vivier wrote:
> Le 02/07/2019 à 19:05, address@hidden a écrit :
>> Patchew URL: https://patchew.org/QEMU/address@hidden/
> ...
>> PASS 2 qmp-test /x86_64/qmp/oob
>> PASS 3 qmp-test /x86_64/qmp/preconfig
>> PASS 4 qmp-test /x86_64/qmp/missing-any-arg
>> ---
>> PASS 5 device-introspect-test /x86_64/device/introspect/abstract-interfaces
>>
>> =================================================================
>> ==10595==ERROR: LeakSanitizer: detected memory leaks
>>
>> Direct leak of 32 byte(s) in 1 object(s) allocated from:
>>     #0 0x55b80fde5b1e in calloc 
>> (/tmp/qemu-test/build/x86_64-softmmu/qemu-system-x86_64+0x19f4b1e)
> 
> I don't see how this series can introduce a memory leak... all changes
> are trivial and there is no memory allocation added.
> 
> So I guess it's a false positive. Any idea?

Unrelated to your series, this commit:

commit c82c7336de58876862e6b4dccbda29e9240fd388
Author: BALATON Zoltan <address@hidden>
Date:   Thu Jun 20 12:55:23 2019 +0200

    ati-vga: Implement DDC and EDID info from monitor

added a call to bitbang_i2c_init() which has some leak.
It was here since 3cd035d863 "GPIO I2C rework" introduced 'Fri Nov 20
23:37:15 2009', but since then the device-introspect test never run a
machine using this device.

Peter sent a fix for this earlier this morning:
"hw/i2c/bitbang_i2c: Use in-place rather than malloc'd
bitbang_i2c_interface struct"

>> ---
>>
>> SUMMARY: AddressSanitizer: 64 byte(s) leaked in 2 allocation(s).
>> /tmp/qemu-test/src/tests/libqtest.c:137: kill_qemu() tried to terminate QEMU 
>> process but encountered exit status 1
>> ERROR - too few tests run (expected 6, got 5)
>> make: *** [/tmp/qemu-test/src/tests/Makefile.include:894: 
>> check-qtest-x86_64] Error 1
>> make: *** Waiting for unfinished jobs....
>> Traceback (most recent call last):
>>
>>
>> The full log is available at
>> http://patchew.org/logs/address@hidden/testing.asan/?type=message.
>> ---
>> Email generated automatically by Patchew [https://patchew.org/].
>> Please send your feedback to address@hidden
>>
> 
>