[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL v2 02/12] CODING_STYLE: specify the indent rule for
From: |
Laurent Vivier |
Subject: |
[Qemu-trivial] [PULL v2 02/12] CODING_STYLE: specify the indent rule for multiline code |
Date: |
Fri, 3 May 2019 13:26:44 +0200 |
From: Wei Yang <address@hidden>
We didn't specify the indent rule for multiline code here, which may
mislead users. And in current code, the code use various styles.
Add this rule in CODING_STYLE to make sure this is clear to every one.
Signed-off-by: Wei Yang <address@hidden>
Suggested-by: Igor Mammedov <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Reviewed-by: Stefano Garzarella <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
CODING_STYLE | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/CODING_STYLE b/CODING_STYLE
index ec075dedc4a8..90321e9c2821 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -29,6 +29,45 @@ Spaces of course are superior to tabs because:
Do not leave whitespace dangling off the ends of lines.
+1.1 Multiline Indent
+
+There are several places where indent is necessary:
+
+ - if/else
+ - while/for
+ - function definition & call
+
+When breaking up a long line to fit within line width, we need a proper indent
+for the following lines.
+
+In case of if/else, while/for, align the secondary lines just after the
+opening parenthesis of the first.
+
+For example:
+
+ if (a == 1 &&
+ b == 2) {
+
+ while (a == 1 &&
+ b == 2) {
+
+In case of function, there are several variants:
+
+ * 4 spaces indent from the beginning
+ * align the secondary lines just after the opening parenthesis of the
+ first
+
+For example:
+
+ do_something(x, y,
+ z);
+
+ do_something(x, y,
+ z);
+
+ do_something(x, do_another(y,
+ z));
+
2. Line width
Lines should be 80 characters; try not to make them longer.
--
2.20.1
- [Qemu-trivial] [PULL v2 04/12] doc: fix the configuration path, (continued)
- [Qemu-trivial] [PULL v2 04/12] doc: fix the configuration path, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 06/12] configure: fix pam test warning, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 03/12] CODING_STYLE: indent example code as all others, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 02/12] CODING_STYLE: specify the indent rule for multiline code, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 07/12] Update configure, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 05/12] qom: use object_new_with_type in object_new_with_propv, Laurent Vivier, 2019/05/03
- Re: [Qemu-trivial] [PULL v2 00/12] Trivial branch patches, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 00/12] Trivial branch patches, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 01/12] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of printf, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 06/12] configure: fix pam test warning, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 02/12] CODING_STYLE: specify the indent rule for multiline code,
Laurent Vivier <=
- [Qemu-trivial] [PULL v2 03/12] CODING_STYLE: indent example code as all others, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 07/12] Update configure, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 08/12] Header cleanups, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 09/12] net: Print output of "-net nic, model=help" to stdout instead of stderr, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 04/12] doc: fix the configuration path, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 12/12] sockets: avoid string truncation warnings when copying UNIX path, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 05/12] qom: use object_new_with_type in object_new_with_propv, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 10/12] Makefile: Let the 'clean' rule remove qemu-ga.exe on Windows hosts, Laurent Vivier, 2019/05/03
- [Qemu-trivial] [PULL v2 11/12] hw/sparc/leon3: Allow load of uImage firmwares, Laurent Vivier, 2019/05/03
- Re: [Qemu-trivial] [Qemu-devel] [PULL v2 00/12] Trivial branch patches, Laurent Vivier, 2019/05/07