[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/9] cpu/topology: add struct Cpu
From: |
Alex Bennée |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/9] cpu/topology: add struct CpuTopology to MachineState |
Date: |
Fri, 29 Mar 2019 09:22:42 +0000 |
User-agent: |
mu4e 1.1.0; emacs 26.1 |
Like Xu <address@hidden> writes:
> Signed-off-by: Like Xu <address@hidden>
> ---
> include/hw/arm/virt.h | 2 +-
> include/hw/boards.h | 8 ++++++++
> include/sysemu/sysemu.h | 2 +-
> vl.c | 7 ++++++-
> 4 files changed, 16 insertions(+), 3 deletions(-)
>
> diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h
> index 507517c..724da0c 100644
> --- a/include/hw/arm/virt.h
> +++ b/include/hw/arm/virt.h
> @@ -123,7 +123,7 @@ typedef struct {
> struct arm_boot_info bootinfo;
> MemMapEntry *memmap;
> const int *irqmap;
> - int smp_cpus;
> + unsigned int smp_cpus;
This seem unrelated to the rest of the change.
> void *fdt;
> int fdt_size;
<snip>
> diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
> index 6065d9e..c0d7d7c 100644
> --- a/include/sysemu/sysemu.h
> +++ b/include/sysemu/sysemu.h
> @@ -100,7 +100,7 @@ extern const char *keyboard_layout;
> extern int win2k_install_hack;
> extern int alt_grab;
> extern int ctrl_grab;
> -extern int smp_cpus;
> +extern unsigned int smp_cpus;
Along with this. Is this meant to align with what is currently defined
as smp_cpus in vl.c? Maybe these changes should be rolled together with
that before the patch to introduce the new topology structure?
--
Alex Bennée