[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/4] HMP: Prepend errors with 'Er
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/4] HMP: Prepend errors with 'Error:' |
Date: |
Tue, 12 Feb 2019 15:11:23 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/12/19 2:47 PM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> Always make error messages start with 'Error:' as a fallback
> to make sure that anything parsing them can tell it failed.
>
> Note: Some places don't use hmp_handle_error
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hmp.c b/hmp.c
> index b2a2b1f84e..4d14718fea 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -62,7 +62,7 @@ static void hmp_handle_error(Monitor *mon, Error **errp)
> {
> assert(errp);
> if (*errp) {
> - error_report_err(*errp);
> + error_reportf_err(*errp, "Error: ");
> }
> }
>
>
- [Qemu-trivial] [PATCH 0/4] a few trivials, Dr. David Alan Gilbert (git), 2019/02/12
- [Qemu-trivial] [PATCH 1/4] pckbd: Convert DPRINTF->trace, Dr. David Alan Gilbert (git), 2019/02/12
- [Qemu-trivial] [PATCH 2/4] HMP: Prepend errors with 'Error:', Dr. David Alan Gilbert (git), 2019/02/12
- [Qemu-trivial] [PATCH 3/4] kvm: Add kvm_set_ioeventfd* traces, Dr. David Alan Gilbert (git), 2019/02/12
- [Qemu-trivial] [PATCH 4/4] wavcapture: Convert to error_report, Dr. David Alan Gilbert (git), 2019/02/12
- Re: [Qemu-trivial] [PATCH 0/4] a few trivials, Michael S. Tsirkin, 2019/02/12