[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 02/30] virtio: pass argument by value for virtqueue
From: |
Laurent Vivier |
Subject: |
[Qemu-trivial] [PULL 02/30] virtio: pass argument by value for virtqueue_map_iovec() |
Date: |
Tue, 11 Dec 2018 19:03:24 +0100 |
From: Dongli Zhang <address@hidden>
Pass num_sg by value instead of by pointer, as num_sg is never modified in
virtqueue_map_iovec().
Signed-off-by: Dongli Zhang <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
hw/virtio/virtio.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 5828ed14df..22bd1ac34e 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -796,13 +796,13 @@ static void virtqueue_undo_map_desc(unsigned int out_num,
unsigned int in_num,
}
static void virtqueue_map_iovec(VirtIODevice *vdev, struct iovec *sg,
- hwaddr *addr, unsigned int *num_sg,
+ hwaddr *addr, unsigned int num_sg,
int is_write)
{
unsigned int i;
hwaddr len;
- for (i = 0; i < *num_sg; i++) {
+ for (i = 0; i < num_sg; i++) {
len = sg[i].iov_len;
sg[i].iov_base = dma_memory_map(vdev->dma_as,
addr[i], &len, is_write ?
@@ -821,8 +821,8 @@ static void virtqueue_map_iovec(VirtIODevice *vdev, struct
iovec *sg,
void virtqueue_map(VirtIODevice *vdev, VirtQueueElement *elem)
{
- virtqueue_map_iovec(vdev, elem->in_sg, elem->in_addr, &elem->in_num, 1);
- virtqueue_map_iovec(vdev, elem->out_sg, elem->out_addr, &elem->out_num, 0);
+ virtqueue_map_iovec(vdev, elem->in_sg, elem->in_addr, elem->in_num, 1);
+ virtqueue_map_iovec(vdev, elem->out_sg, elem->out_addr, elem->out_num, 0);
}
static void *virtqueue_alloc_element(size_t sz, unsigned out_num, unsigned
in_num)
--
2.19.2
- [Qemu-trivial] [PULL 00/30] Trivial patches, Laurent Vivier, 2018/12/11
- [Qemu-trivial] [PULL 04/30] hw: set_netdev: remove useless code, Laurent Vivier, 2018/12/11
- [Qemu-trivial] [PULL 06/30] misc: Avoid UTF-8 in error messages, Laurent Vivier, 2018/12/11
- [Qemu-trivial] [PULL 07/30] MAINTAINERS: Add missing hw/pci-host entries, Laurent Vivier, 2018/12/11
- [Qemu-trivial] [PULL 03/30] misc: fix spelling, Laurent Vivier, 2018/12/11
- [Qemu-trivial] [PULL 10/30] MAINTAINERS: Fix ACPI tests data files path, Laurent Vivier, 2018/12/11
- [Qemu-trivial] [PULL 13/30] MAINTAINERS: Add missing entries for the Jazz machine, Laurent Vivier, 2018/12/11
- [Qemu-trivial] [PULL 09/30] target: hax: replace g_malloc with g_new0, Laurent Vivier, 2018/12/11
- [Qemu-trivial] [PULL 02/30] virtio: pass argument by value for virtqueue_map_iovec(),
Laurent Vivier <=
- [Qemu-trivial] [PULL 11/30] MAINTAINERS: Add a missing entry to the SPARC CPU, Laurent Vivier, 2018/12/11
- [Qemu-trivial] [PULL 23/30] MAINTAINERS: Add a missing entry for the NVDIMM device, Laurent Vivier, 2018/12/11
- [Qemu-trivial] [PULL 30/30] Fixes i386 xchgq test, Laurent Vivier, 2018/12/11
- [Qemu-trivial] [PULL 22/30] MAINTAINERS: Add a missing entry to the QMP section, Laurent Vivier, 2018/12/11
- [Qemu-trivial] [PULL 05/30] qapi: Reduce Makefile boilerplate, Laurent Vivier, 2018/12/11
- [Qemu-trivial] [PULL 12/30] MAINTAINERS: Add missing entries for the Xilinx ZynqMP machine, Laurent Vivier, 2018/12/11
- [Qemu-trivial] [PULL 26/30] util: vfio-helpers: use ARRAY_SIZE in qemu_vfio_init_pci(), Laurent Vivier, 2018/12/11
- [Qemu-trivial] [PULL 25/30] target: hax: fix errors in comment, Laurent Vivier, 2018/12/11
- [Qemu-trivial] [PULL 18/30] MAINTAINERS: Add missing entries to the vhost section, Laurent Vivier, 2018/12/11
- [Qemu-trivial] [PULL 15/30] MAINTAINERS: Add a missing entry for the Old World machines, Laurent Vivier, 2018/12/11