[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] Fixes i386 xchgq test
From: |
Richard Henderson |
Subject: |
Re: [Qemu-trivial] [PATCH] Fixes i386 xchgq test |
Date: |
Mon, 10 Dec 2018 13:42:24 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 12/10/18 1:26 PM, Philippe Mathieu-Daudé wrote:
> Hi Fabrice,
>
> On Fri, Dec 7, 2018 at 5:06 PM <address@hidden> wrote:
>>
>> As "xchg" reads and writes both operands, the "+m" is required to avoid
>> undefined behavior on -O2 compilation.
>>
>> Signed-off-by: Fabrice Desclaux <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
>> ---
>> tests/tcg/i386/test-i386.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/tcg/i386/test-i386.c b/tests/tcg/i386/test-i386.c
>> index a29b41e764..18d5609665 100644
>> --- a/tests/tcg/i386/test-i386.c
>> +++ b/tests/tcg/i386/test-i386.c
>> @@ -1137,7 +1137,7 @@ void test_xchg(void)
>> TEST_XCHG(xchgb, "b", "+q");
>>
>> #if defined(__x86_64__)
>> - TEST_XCHG(xchgq, "", "=m");
>> + TEST_XCHG(xchgq, "", "+m");
>> #endif
>> TEST_XCHG(xchgl, "k", "+m");
>> TEST_XCHG(xchgw, "w", "+m");
>> --
>> 2.19.2
>
> All QEMU patches has to go via the address@hidden list (you
> only sent it to the trivial list).
> I'm also Cc'ing the maintainers:
Thanks, Phil.
r~