[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v3 38/41] hw/rdma: Use the BYTE-based definiti
From: |
Yuval Shaia |
Subject: |
Re: [Qemu-trivial] [PATCH v3 38/41] hw/rdma: Use the BYTE-based definitions |
Date: |
Sat, 21 Apr 2018 20:55:03 +0300 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Sun, Apr 15, 2018 at 08:43:04PM -0300, Philippe Mathieu-Daudé wrote:
> It eases code review, unit is explicit.
>
> Patch generated using:
>
> $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/
>
> and modified manually.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/rdma/vmw/pvrdma.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/rdma/vmw/pvrdma.h b/hw/rdma/vmw/pvrdma.h
> index 8c173cb824..f17143f0e6 100644
> --- a/hw/rdma/vmw/pvrdma.h
> +++ b/hw/rdma/vmw/pvrdma.h
> @@ -16,6 +16,7 @@
> #ifndef PVRDMA_PVRDMA_H
> #define PVRDMA_PVRDMA_H
>
> +#include "qemu/units.h"
> #include "hw/pci/pci.h"
> #include "hw/pci/msix.h"
>
> @@ -30,7 +31,7 @@
> #define RDMA_MSIX_BAR_IDX 0
> #define RDMA_REG_BAR_IDX 1
> #define RDMA_UAR_BAR_IDX 2
> -#define RDMA_BAR0_MSIX_SIZE (16 * 1024)
> +#define RDMA_BAR0_MSIX_SIZE (16 * K_BYTE)
> #define RDMA_BAR1_REGS_SIZE 256
> #define RDMA_BAR2_UAR_SIZE (0x1000 * MAX_UCS) /* each uc gets page */
Reviewed-by: Yuval Shaia <address@hidden>
>
> --
> 2.17.0
>
- [Qemu-trivial] [PATCH v3 33/41] hw/net: Use the BYTE-based definitions, (continued)
- [Qemu-trivial] [PATCH v3 33/41] hw/net: Use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/04/15
- [Qemu-trivial] [PATCH v3 34/41] hw/usb: Use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/04/15
- [Qemu-trivial] [PATCH v3 35/41] hw/sd: Use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/04/15
- [Qemu-trivial] [PATCH v3 36/41] hw/vfio: Use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/04/15
- [Qemu-trivial] [PATCH v3 37/41] hw/virtio: Use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/04/15
- [Qemu-trivial] [PATCH v3 38/41] hw/rdma: Use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/04/15
- [Qemu-trivial] [PATCH v3 39/41] hw/nvdimm: Use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/04/15
- [Qemu-trivial] [PATCH v3 40/41] hw/loader: Use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/04/15
- [Qemu-trivial] [PATCH v3 41/41] cutils: Do not include "qemu/units.h" directly, Philippe Mathieu-Daudé, 2018/04/15
- Message not available
- Message not available