[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v3 01/41] hw: Clean "hw/devices.h" includes
From: |
Thomas Huth |
Subject: |
Re: [Qemu-trivial] [PATCH v3 01/41] hw: Clean "hw/devices.h" includes |
Date: |
Mon, 16 Apr 2018 06:53:22 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 16.04.2018 01:42, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> include/hw/devices.h | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/include/hw/devices.h b/include/hw/devices.h
> index 861ddea8af..0e27feb0c2 100644
> --- a/include/hw/devices.h
> +++ b/include/hw/devices.h
> @@ -1,13 +1,10 @@
> #ifndef QEMU_DEVICES_H
> #define QEMU_DEVICES_H
>
> -#include "hw/irq.h"
> -
> -/* ??? Not all users of this file can include cpu-common.h. */
> -struct MemoryRegion;
> -
> /* Devices that have nowhere better to go. */
>
> +#include "hw/hw.h"
> +
> /* smc91c111.c */
> void smc91c111_init(NICInfo *, uint32_t, qemu_irq);
IMHO we should rather get rid of devices.h (in a separate patch series)
and introduce proper small headers à la smc91c111.h for the single
sections in here... Just my 0.02 €.
Thomas
- [Qemu-trivial] [PATCH v3 00/41] hw: Use the BYTE-based definitions when useful, Philippe Mathieu-Daudé, 2018/04/15
- [Qemu-trivial] [PATCH v3 01/41] hw: Clean "hw/devices.h" includes, Philippe Mathieu-Daudé, 2018/04/15
- Re: [Qemu-trivial] [PATCH v3 01/41] hw: Clean "hw/devices.h" includes,
Thomas Huth <=
- [Qemu-trivial] [PATCH v3 02/41] hw: Do not include "sysemu/block-backend.h" if it is not necessary, Philippe Mathieu-Daudé, 2018/04/15
- [Qemu-trivial] [PATCH v3 03/41] hw/block/nvme: Include the "qemu/cutils.h" in the source file, Philippe Mathieu-Daudé, 2018/04/15
- [Qemu-trivial] [PATCH v3 04/41] hw/misc/mips_itu: Sort includes, Philippe Mathieu-Daudé, 2018/04/15
- [Qemu-trivial] [PATCH v3 05/41] hw/mips/r4k: Constify params_size, Philippe Mathieu-Daudé, 2018/04/15
- [Qemu-trivial] [PATCH v3 06/41] cutils: Extract byte-based definitions into a new header: "qemu/units.h", Philippe Mathieu-Daudé, 2018/04/15
- [Qemu-trivial] [PATCH v3 07/41] hw/ivshmem: Use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/04/15
- [Qemu-trivial] [PATCH v3 08/41] hw/ipack: Use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/04/15
- [Qemu-trivial] [PATCH v3 09/41] hw/scsi: Use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/04/15
- [Qemu-trivial] [PATCH v3 10/41] hw/smbios: Use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/04/15