[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/3] hw/core: fix missing return
From: |
Alistair Francis |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/3] hw/core: fix missing return value in load_image_targphys_as() |
Date: |
Mon, 26 Jun 2017 15:36:41 -0700 |
On Fri, Jun 23, 2017 at 9:45 AM, Philippe Mathieu-Daudé <address@hidden> wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Thanks,
Alistair
> ---
> hw/core/loader.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/core/loader.c b/hw/core/loader.c
> index 094f24627f..e137e772ae 100644
> --- a/hw/core/loader.c
> +++ b/hw/core/loader.c
> @@ -150,7 +150,9 @@ int load_image_targphys_as(const char *filename,
> return -1;
> }
> if (size > 0) {
> - rom_add_file_fixed_as(filename, addr, -1, as);
> + if (rom_add_file_fixed_as(filename, addr, -1, as) < 0) {
> + return -1;
> + }
> }
> return size;
> }
> --
> 2.13.1
>
>