[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] Separate function types from opaque types in
From: |
Juan Quintela |
Subject: |
Re: [Qemu-trivial] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h |
Date: |
Thu, 22 Jun 2017 19:03:13 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Greg Kurz <address@hidden> wrote:
> On Thu, 22 Jun 2017 17:14:08 +0100
> Peter Maydell <address@hidden> wrote:
>
>> On 22 June 2017 at 17:06, Greg Kurz <address@hidden> wrote:
>> > Function types cannot reside in the same sorted list as opaque types since
>> > they may depend on a type which would be defined later.
>> >
>> > Of course, the same problem could arise if a function type depends on
>> > another function type with greater alphabetical order. Hopefully we
>> > don't have that at this time.
>>
>> The other approach would be to put function types somewhere
>> else and leave typedefs.h for the simple 'opaque types
>> for structures' that it was started as.
>>
>> For instance we have include/qemu/fprintf-fn.h as a precedent.
>>
>
> Indeed, and I'm not quite sure why Juan decided to put these types into
> typedefs.h instead of a dedicated header file in include/migration... is
> it only because it was the quickest fix ?
All other typedefs were defined there. I can create a different include
file, but I think that is "overengineering", no? They are typedefs,
just not of structs. But I agree that they are the only ones.
Later, Juan.
- [Qemu-trivial] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Greg Kurz, 2017/06/22
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Peter Maydell, 2017/06/22
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Greg Kurz, 2017/06/22
- Re: [Qemu-trivial] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h,
Juan Quintela <=
- Re: [Qemu-trivial] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Peter Maydell, 2017/06/22
- Re: [Qemu-trivial] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Dr. David Alan Gilbert, 2017/06/22
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Greg Kurz, 2017/06/22
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Dr. David Alan Gilbert, 2017/06/22
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Thomas Huth, 2017/06/22
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Peter Maydell, 2017/06/22
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Dr. David Alan Gilbert, 2017/06/22
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Greg Kurz, 2017/06/22
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Dr. David Alan Gilbert, 2017/06/26
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h, Markus Armbruster, 2017/06/23