|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [Qemu-trivial] [PATCH] coccinelle: fix typo in comment |
Date: | Sat, 20 May 2017 00:34:29 -0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 05/16/2017 11:35 AM, Eric Blake wrote:
On 05/15/2017 07:11 PM, Philippe Mathieu-Daudé wrote:Signed-off-by: Philippe Mathieu-Daudé <address@hidden> --- scripts/coccinelle/return_directly.cocci | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Did you intend for this to be threaded with your other 'oslib: strip trailing '\n'...' patch? If so, where's the 0/2 cover letter and proper subject lines?
Hi Eric, I think I did a mistake in my command, I intended to generate the patches in the same branch but wanted to send them as unrelated (without cover). I didn't noticed while sending until your remark, I'll double-check next time!
At any rate, Reviewed-by: Eric Blake <address@hidden>
Thanks!
diff --git a/scripts/coccinelle/return_directly.cocci b/scripts/coccinelle/return_directly.cocci index 48680f2c2a..4cf50e75ea 100644 --- a/scripts/coccinelle/return_directly.cocci +++ b/scripts/coccinelle/return_directly.cocci @@ -1,4 +1,4 @@ -// replace 'R = X; return R;' with 'return R;' +// replace 'R = X; return R;' with 'return X;' @@ identifier VAR; expression E;
[Prev in Thread] | Current Thread | [Next in Thread] |