[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] hw/xtensa: sim: use g_string/g_n
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] hw/xtensa: sim: use g_string/g_new |
Date: |
Tue, 09 May 2017 10:00:32 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Max Filippov <address@hidden> writes:
> Replace malloc/free/sprintf with g_string/g_string_printf/g_string_free.
> Replace g_malloc with g_new when allocating the MemoryRegion to get more
> type safety.
>
> Suggested-by: Alex Bennée <address@hidden>
> Signed-off-by: Max Filippov <address@hidden>
> ---
> hw/xtensa/sim.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/hw/xtensa/sim.c b/hw/xtensa/sim.c
> index d2d1d3a..b27e28d 100644
> --- a/hw/xtensa/sim.c
> +++ b/hw/xtensa/sim.c
> @@ -41,21 +41,21 @@ static void xtensa_create_memory_regions(const
> XtensaMemory *memory,
> const char *name)
> {
> unsigned i;
> - char *num_name = malloc(strlen(name) + sizeof(i) * 3 + 1);
> + GString *num_name = g_string_new(NULL);
>
> for (i = 0; i < memory->num; ++i) {
> MemoryRegion *m;
>
> - sprintf(num_name, "%s%u", name, i);
> - m = g_malloc(sizeof(*m));
> - memory_region_init_ram(m, NULL, num_name,
> + g_string_printf(num_name, "%s%u", name, i);
I'd make that
num_name = g_strdup_printf("%s%u, name, i);
for less churn. Have to free(num_name) in the loop, of course.
> + m = g_new(MemoryRegion, 1);
> + memory_region_init_ram(m, NULL, num_name->str,
> memory->location[i].size,
> &error_fatal);
> vmstate_register_ram_global(m);
> memory_region_add_subregion(get_system_memory(),
> memory->location[i].addr, m);
> }
> - free(num_name);
> + g_string_free(num_name, true);
> }
>
> static uint64_t translate_phys_addr(void *opaque, uint64_t addr)