[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 04/11] ide/ahci: add missing incl
From: |
Eric Blake |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 04/11] ide/ahci: add missing includes |
Date: |
Mon, 8 May 2017 18:58:46 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 05/08/2017 06:39 PM, Philippe Mathieu-Daudé wrote:
> qemu/include/hw/ide/ahci.h:260:16: error: field ‘sglist’ has incomplete type
> QEMUSGList sglist;
> ^~~~~~
What are you doing to get this compilation error (configure options,
platform, compiler, etc)? I can't reproduce it. Is it something that
pops up later when you remove includes from somewhere else, and you're
just pre-emptively adding includes here to allow removal of includes later?
> /qemu/include/hw/ide/ahci.h:272:5: error: unknown type name ‘IDEDMA’
> IDEDMA dma;
> ^~~~~~
> qemu/include/hw/ide/ahci.h:273:5: error: unknown type name ‘IDEBus’
> IDEBus port;
> ^~~~~~
> qemu/include/hw/ide/ahci.h:305:15: error: field ‘parent_obj’ has incomplete
> type
> PCIDevice parent_obj;
> ^~~~~~~~~~
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> include/hw/ide/ahci.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/hw/ide/ahci.h b/include/hw/ide/ahci.h
> index 0ca7c65820..293f9ebcd0 100644
> --- a/include/hw/ide/ahci.h
> +++ b/include/hw/ide/ahci.h
> @@ -25,6 +25,8 @@
> #define HW_IDE_AHCI_H
>
> #include "hw/sysbus.h"
> +#include "hw/ide/internal.h"
> +#include "sysemu/dma.h"
>
> #define AHCI_MEM_BAR_SIZE 0x1000
> #define AHCI_MAX_PORTS 32
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 03/11] hw/misc: add missing includes, (continued)
[Qemu-trivial] [PATCH 01/11] hw/net: removed obsolete comments, Philippe Mathieu-Daudé, 2017/05/08
[Qemu-trivial] [PATCH 05/11] hw/mips: add missing include, Philippe Mathieu-Daudé, 2017/05/08
[Qemu-trivial] [PATCH 06/11] hw/arm: removed unnecessary include, Philippe Mathieu-Daudé, 2017/05/08
[Qemu-trivial] [PATCH 04/11] ide/ahci: add missing includes, Philippe Mathieu-Daudé, 2017/05/08
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 04/11] ide/ahci: add missing includes,
Eric Blake <=
[Qemu-trivial] [PATCH 08/11] hw/sparc: use ARRAY_SIZE() macro, Philippe Mathieu-Daudé, 2017/05/08
[Qemu-trivial] [PATCH 09/11] target/sparc: fix DEBUG_MMU DPRINTF() arguments, Philippe Mathieu-Daudé, 2017/05/08
[Qemu-trivial] [PATCH 10/11] register: display register prefix (name) since it is available, Philippe Mathieu-Daudé, 2017/05/08