[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 06/23] usb-ccid: make ccid_write_data_block() cope
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 06/23] usb-ccid: make ccid_write_data_block() cope with null buffers |
Date: |
Sun, 7 May 2017 10:02:09 +0300 |
From: Philippe Mathieu-Daudé <address@hidden>
static code analyzer complain:
hw/usb/dev-smartcard-reader.c:816:5: warning: Null pointer passed as an
argument to a 'nonnull' parameter
memcpy(p->abData, data, len);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
hw/usb/dev-smartcard-reader.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c
index 757b8b3f5a..49cb1829b5 100644
--- a/hw/usb/dev-smartcard-reader.c
+++ b/hw/usb/dev-smartcard-reader.c
@@ -813,7 +813,10 @@ static void ccid_write_data_block(USBCCIDState *s, uint8_t
slot, uint8_t seq,
if (p->b.bError) {
DPRINTF(s, D_VERBOSE, "error %d\n", p->b.bError);
}
- memcpy(p->abData, data, len);
+ if (len) {
+ g_assert_nonnull(data);
+ memcpy(p->abData, data, len);
+ }
ccid_reset_error_status(s);
usb_wakeup(s->bulk, 0);
}
--
2.11.0
- [Qemu-trivial] [PULL 00/23] Trivial patches for 2017-05-07, Michael Tokarev, 2017/05/07
- [Qemu-trivial] [PULL 08/23] qga: fix compiler warnings (clang 5), Michael Tokarev, 2017/05/07
- [Qemu-trivial] [PULL 12/23] use _Static_assert in QEMU_BUILD_BUG_ON, Michael Tokarev, 2017/05/07
- [Qemu-trivial] [PULL 11/23] channel-file: fix wrong parameter comments, Michael Tokarev, 2017/05/07
- [Qemu-trivial] [PULL 01/23] Remove reduntant qemu: from error functions, Michael Tokarev, 2017/05/07
- [Qemu-trivial] [PULL 09/23] util: Use g_malloc/g_free in envlist.c, Michael Tokarev, 2017/05/07
- [Qemu-trivial] [PULL 19/23] tests: Ignore another built executable (test-hmp), Michael Tokarev, 2017/05/07
- [Qemu-trivial] [PULL 14/23] virtio-blk: Remove useless condition around g_free(), Michael Tokarev, 2017/05/07
- [Qemu-trivial] [PULL 06/23] usb-ccid: make ccid_write_data_block() cope with null buffers,
Michael Tokarev <=
- [Qemu-trivial] [PULL 15/23] hw/core/generic-loader: Fix crash when running without CPU, Michael Tokarev, 2017/05/07
- [Qemu-trivial] [PULL 23/23] tests: Remove redundant assignment, Michael Tokarev, 2017/05/07
- [Qemu-trivial] [PULL 13/23] qemu-doc: Fix broken URLs of amnhltm.zip and dosidle210.zip, Michael Tokarev, 2017/05/07
- [Qemu-trivial] [PULL 04/23] Add 'none' as type for drive's if option, Michael Tokarev, 2017/05/07
- [Qemu-trivial] [PULL 02/23] ppc_booke: drop useless assignment, Michael Tokarev, 2017/05/07
- [Qemu-trivial] [PULL 07/23] device_tree: fix compiler warnings (clang 5), Michael Tokarev, 2017/05/07
- [Qemu-trivial] [PULL 18/23] scripts: Switch to more portable Perl shebang, Michael Tokarev, 2017/05/07
- [Qemu-trivial] [PULL 22/23] MAINTAINERS: Update paths for AioContext implementation, Michael Tokarev, 2017/05/07
- [Qemu-trivial] [PULL 10/23] block: Make 'replication_state' an enum, Michael Tokarev, 2017/05/07
- [Qemu-trivial] [PULL 17/23] scripts/qemu-binfmt-conf.sh: Fix shell portability issue, Michael Tokarev, 2017/05/07