[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] jazz_led: fix bad snprintf
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-trivial] [PATCH] jazz_led: fix bad snprintf |
Date: |
Fri, 5 May 2017 09:22:31 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 05/05/2017 08:24, Michael Tokarev wrote:
> 03.05.2017 13:44, Paolo Bonzini wrote:
>> Detected by GCC 7's -Wformat-truncation. snprintf writes at most
>> 2 bytes here including the terminating NUL, so the result is
>> truncated. In addition, the newline at the end is pointless.
>> Fix the buffer size and the format string.
>
> Polo, that's quite a bit too bureaucratic,
> but where's your s-o-b for this patch? :)
Oops, here:
Signed-off-by: Paolo Bonzini <address@hidden>
Paolo
>
> Thanks,
>
> /mjt
>
Re: [Qemu-trivial] [PATCH] jazz_led: fix bad snprintf, Michael Tokarev, 2017/05/05
- Re: [Qemu-trivial] [PATCH] jazz_led: fix bad snprintf,
Paolo Bonzini <=
Re: [Qemu-trivial] [PATCH] jazz_led: fix bad snprintf, Michael Tokarev, 2017/05/05