[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 0/1] Developer Conveniences - che
From: |
Eric Blake |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 0/1] Developer Conveniences - check for _Static_assert and use in QEMU_BUILD_BUG_ON |
Date: |
Tue, 14 Mar 2017 09:58:31 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 03/14/2017 09:44 AM, Andreas Grapentin wrote:
>
> (as taken from here: http://wiki.qemu-project.org/Contribute/BiteSizedTasks)
>
A single patch can be sent without a cover letter if desired (0/N cover
letters are only mandatory on patch series). In fact, much of the
information you give here:
>
> I added a configure check for C11's _Static_assert, and based on the outcome,
> QEMU_BUILD_BUG_ON will now produce slightly more readable results on failures.
>
> Systems without C11 conforming compilers will still have the old messages, as
> verified by intentionally breaking the configure check.
>
> the following example output was generated by inverting the condition in
> QEMU_BUILD_BUG_ON:
>
> without _Static_assert:
>
...
> with _Static_assert:
>
>> In file included from
>> /home/andi/research/qemu-shared-memory/qemu/include/qemu/osdep.h:36:0,
>> from
>> /home/andi/research/qemu-shared-memory/qemu/qga/commands.c:13:
>> /home/andi/research/qemu-shared-memory/qemu/qga/commands.c: In function
>> ‘qmp_guest_exec_status’:
>> /home/andi/research/qemu-shared-memory/qemu/include/qemu/compiler.h:94:30:
>> error: static assertion failed: "sizeof(*&gei->finished) > sizeof(void *)"
>> #define QEMU_BUILD_BUG_ON(x) _Static_assert((x), #x)
>> ^
should be in the commit message of the actual patch (right now, your 1/1
message has a rather blank commit message).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature