[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 08/52] gdbstub: set listen backlog to 1
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 08/52] gdbstub: set listen backlog to 1 |
Date: |
Sun, 5 Jun 2016 10:42:45 +0300 |
From: Peter Wu <address@hidden>
Avoid possible connection drops on Linux (when tcp_syncookies is
disabled) or fallbacks to SYN cookies with the following kernel warning:
TCP: request_sock_TCP: Possible SYN flooding on port 1234. Sending cookies.
Check SNMP counters.
Since Linux 4.4 (ef547f2ac16b "tcp: remove max_qlen_log"), a backlog of
zero is really treated as the "queue length for completely established
sockets waiting to be accepted" (listen(2)). This is apparently a valid
interpretation of an "implementation-defined minimum value" for a
backlog value of 0 (listen(3p)). Previous kernels would use 8 as
minimum value, but that is no longer the case.
Signed-off-by: Peter Wu <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
gdbstub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdbstub.c b/gdbstub.c
index b9e3710..ffcad0e 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1629,7 +1629,7 @@ static int gdbserver_open(int port)
close(fd);
return -1;
}
- ret = listen(fd, 0);
+ ret = listen(fd, 1);
if (ret < 0) {
perror("listen");
close(fd);
--
2.1.4
- [Qemu-trivial] [PULL 00/52] Trivial patches for 2016-06-05, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 11/52] remove useless muldiv64(), Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 10/52] The only 64bit parameter of muldiv64() is the first one., Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 06/52] target-moxie: Remove unused struct elements, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 08/52] gdbstub: set listen backlog to 1,
Michael Tokarev <=
- [Qemu-trivial] [PULL 09/52] scripts: add muldiv64() checking coccinelle scripts, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 19/52] monitor: Typo fix, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 20/52] qdev: Clean up around properties, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 31/52] all: Remove unnecessary glib.h includes, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 14/52] Fix linking relocatable objects on Sparc, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 25/52] Fix configure test for PBKDF2 in nettle, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 07/52] po/Makefile: call rm -f directly, Michael Tokarev, 2016/06/05
- [Qemu-trivial] [PULL 24/52] docs: Fix a couple of typos in throttle.txt, Michael Tokarev, 2016/06/05