[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH 3/6] spice: fix coverity complains
From: |
Gonglei (Arei) |
Subject: |
Re: [Qemu-trivial] [PATCH 3/6] spice: fix coverity complains |
Date: |
Tue, 10 May 2016 05:59:46 +0000 |
Hi Gerd,
Pls pick this one, thanks :)
Regards,
-Gonglei
> -----Original Message-----
> From: Paolo Bonzini [mailto:address@hidden
> Sent: Thursday, March 03, 2016 7:19 PM
> To: Gonglei (Arei); address@hidden
> Cc: address@hidden
> Subject: Re: [PATCH 3/6] spice: fix coverity complains
>
>
>
> On 03/03/2016 10:43, Gonglei wrote:
> > Remove the unnecessary NULL check.
> >
> > Signed-off-by: Gonglei <address@hidden>
> > ---
> > ui/spice-display.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/ui/spice-display.c b/ui/spice-display.c
> > index 242ab5f..1ffbec1 100644
> > --- a/ui/spice-display.c
> > +++ b/ui/spice-display.c
> > @@ -769,9 +769,7 @@ static void
> display_mouse_define(DisplayChangeListener *dcl,
> > SimpleSpiceDisplay *ssd = container_of(dcl, SimpleSpiceDisplay, dcl);
> >
> > qemu_mutex_lock(&ssd->lock);
> > - if (c) {
> > - cursor_get(c);
> > - }
> > + cursor_get(c);
> > cursor_put(ssd->cursor);
> > ssd->cursor = c;
> > ssd->hot_x = c->hot_x;
> >
>
> Reviewed-by: Paolo Bonzini <address@hidden>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-trivial] [PATCH 3/6] spice: fix coverity complains,
Gonglei (Arei) <=