[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PATCH 2/2] hw/display/tcx.c: tcx_realizefn: fix memory l
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PATCH 2/2] hw/display/tcx.c: tcx_realizefn: fix memory leak, make FCode loading error fatal and improve error message |
Date: |
Sat, 30 May 2015 16:54:43 +0300 |
Signed-off-by: Michael Tokarev <address@hidden>
---
hw/display/tcx.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/hw/display/tcx.c b/hw/display/tcx.c
index a9f9f66..c2b32c3 100644
--- a/hw/display/tcx.c
+++ b/hw/display/tcx.c
@@ -1014,10 +1014,13 @@ static void tcx_realizefn(DeviceState *dev, Error
**errp)
if (fcode_filename) {
ret = load_image_targphys(fcode_filename, s->prom_addr,
FCODE_MAX_ROM_SIZE);
- if (ret < 0 || ret > FCODE_MAX_ROM_SIZE) {
- error_report("tcx: could not load prom '%s'", TCX_ROM_FILE);
- }
}
+ if (!fcode_filename || ret < 0 || ret > FCODE_MAX_ROM_SIZE) {
+ error_report("tcx: could not load prom '%s'",
+ fcode_filename ? fcode_filename : TCX_ROM_FILE);
+ exit(1);
+ }
+ g_free(fcode_filename);
/* 0/DFB8 : 8-bit plane */
s->vram = vram_base;
--
2.1.4
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-trivial] [PATCH 2/2] hw/display/tcx.c: tcx_realizefn: fix memory leak, make FCode loading error fatal and improve error message,
Michael Tokarev <=