[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH v2 1/4] hw/display/cg3.c: Fix mem
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH v2 1/4] hw/display/cg3.c: Fix memory leak |
Date: |
Fri, 29 May 2015 09:59:52 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Shannon Zhao <address@hidden> writes:
> From: Shannon Zhao <address@hidden>
>
> Signed-off-by: Shannon Zhao <address@hidden>
> Signed-off-by: Shannon Zhao <address@hidden>
Suffering an identity crisis? ;)
> ---
> hw/display/cg3.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/display/cg3.c b/hw/display/cg3.c
> index 1e6ff2b..186d544 100644
> --- a/hw/display/cg3.c
> +++ b/hw/display/cg3.c
> @@ -303,8 +303,9 @@ static void cg3_realizefn(DeviceState *dev, Error **errp)
> ret = load_image_targphys(fcode_filename, s->prom_addr,
> FCODE_MAX_ROM_SIZE);
> if (ret < 0 || ret > FCODE_MAX_ROM_SIZE) {
> - error_report("cg3: could not load prom '%s'", CG3_ROM_FILE);
> + error_report("cg3: could not load prom '%s'", fcode_filename);
> }
> + g_free(fcode_filename);
> }
>
> memory_region_init_ram(&s->vram_mem, NULL, "cg3.vram", s->vram_size,
You're also improving an error message. Mentioning that in the commit
message wouldn't hurt.
- [Qemu-trivial] [PATCH v2 0/4] Fix memory leak due to calling qemu_find_file and not freeing return buf, Shannon Zhao, 2015/05/28
- [Qemu-trivial] [PATCH v2 3/4] hw/ppc/e500.c: Fix memory leak, Shannon Zhao, 2015/05/28
- [Qemu-trivial] [PATCH v2 4/4] hw/display/tcx.c: Fix memory leak spotted by valgrind, Shannon Zhao, 2015/05/28
- [Qemu-trivial] [PATCH v2 2/4] hw/alpha/dp264.c: Fix memory leak spotted by valgrind, Shannon Zhao, 2015/05/28
- [Qemu-trivial] [PATCH v2 1/4] hw/display/cg3.c: Fix memory leak, Shannon Zhao, 2015/05/28
- Re: [Qemu-trivial] [Qemu-devel] [PATCH v2 1/4] hw/display/cg3.c: Fix memory leak,
Markus Armbruster <=
- Re: [Qemu-trivial] [PATCH v2 0/4] Fix memory leak due to calling qemu_find_file and not freeing return buf, Michael Tokarev, 2015/05/28