[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] arch_init: Clean up the duplicate variable 'l
From: |
Li, Liang Z |
Subject: |
Re: [Qemu-trivial] [PATCH] arch_init: Clean up the duplicate variable 'len' defining in ram_load() |
Date: |
Fri, 15 May 2015 09:12:45 +0000 |
> Cc: address@hidden; Li, Liang Z; address@hidden; zhanghailiang
> Subject: [PATCH] arch_init: Clean up the duplicate variable 'len' defining in
> ram_load()
>
> There are two places that define 'len' variable, It's OK for compiling, but
> makes it difficult for reading.
>
> Remove the local one which defined in the inside 'while' loop.
>
> Signed-off-by: zhanghailiang <address@hidden>
> ---
> arch_init.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch_init.c b/arch_init.c
> index 23d3feb..8918f6c 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -1593,7 +1593,6 @@ static int ram_load(QEMUFile *f, void *opaque, int
> version_id)
> total_ram_bytes = addr;
> while (!ret && total_ram_bytes) {
> RAMBlock *block;
> - uint8_t len;
> char id[256];
> ram_addr_t length;
>
> --
Yes, It's true.
Liang