[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH 5/9] e500: fix memory leak
From: |
Gonglei |
Subject: |
Re: [Qemu-trivial] [PATCH 5/9] e500: fix memory leak |
Date: |
Sat, 28 Feb 2015 17:57:36 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 2015/2/28 17:41, Michael Tokarev wrote:
> 27.02.2015 10:50, address@hidden wrote:
>> From: Gonglei <address@hidden>
>>
>> Signed-off-by: Gonglei <address@hidden>
>> ---
>> hw/ppc/e500.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
>> index 7e17d18..38203a6 100644
>> --- a/hw/ppc/e500.c
>> +++ b/hw/ppc/e500.c
>> @@ -542,6 +542,7 @@ done:
>>
>> out:
>> g_free(pci_map);
>> + g_free(filename);
>
> This patch breaks compilation, because `filename' variable is
> local to the "if (dtb_file)" code block at the beginning of this
> function and shold be freed there.
>
Yes, it is. Thanks for your review, I'll respin it.
Regards,
-Gonglei
- [Qemu-trivial] [PATCH 0/9] Coverity defects fixes, arei.gonglei, 2015/02/27
- [Qemu-trivial] [PATCH 3/9] sparc/leon3.c: fix memory leak, arei.gonglei, 2015/02/27
- [Qemu-trivial] [PATCH 5/9] e500: fix memory leak, arei.gonglei, 2015/02/27
- [Qemu-trivial] [PATCH 6/9] 9pfs: fix memory leak, arei.gonglei, 2015/02/27
- [Qemu-trivial] [PATCH 4/9] macio: fix possible memory leak, arei.gonglei, 2015/02/27
- [Qemu-trivial] [PATCH 1/9] nbd: fix resource leak, arei.gonglei, 2015/02/27
- [Qemu-trivial] [PATCH 8/9] sysbus: fix memory leak, arei.gonglei, 2015/02/27
- [Qemu-trivial] [PATCH 7/9] milkymist.c: fix memory leak, arei.gonglei, 2015/02/27
- [Qemu-trivial] [PATCH 9/9] microblaze: fix memory leak, arei.gonglei, 2015/02/27
- [Qemu-trivial] [PATCH 2/9] arm: fix memory leak, arei.gonglei, 2015/02/27