[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] vfio: fix wrong initialize vfio_
From: |
Alex Williamson |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] vfio: fix wrong initialize vfio_group_list |
Date: |
Sun, 25 Jan 2015 21:06:20 -0500 (EST) |
----- Original Message -----
> CC: address@hidden
>
> On 01/22/2015 04:14 PM, Eric Auger wrote:
> > Hi Chen,
> >
> > thanks for correcting this mistake I introduced when moving code from
> > pci to common.
>
> so, can you check in this patch?
I've got it queued up and while it's clearly an error, I don't see that the fix
actually changes the resulting code, the parameter is ignored in the macro. Am
I missing something? If that's the case, I'll include it in my next pull
request, but I don't see any pressing reason to rush that request. Thanks,
Alex
> > On 01/22/2015 04:50 AM, Chen Fan wrote:
> >> Signed-off-by: Chen Fan <address@hidden>
> >> ---
> >> hw/vfio/common.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/hw/vfio/common.c b/hw/vfio/common.c
> >> index cf483ff..e71385e 100644
> >> --- a/hw/vfio/common.c
> >> +++ b/hw/vfio/common.c
> >> @@ -32,7 +32,7 @@
> >> #include "trace.h"
> >>
> >> struct vfio_group_head vfio_group_list =
> >> - QLIST_HEAD_INITIALIZER(vfio_address_spaces);
> >> + QLIST_HEAD_INITIALIZER(vfio_group_list);
> >> struct vfio_as_head vfio_address_spaces =
> >> QLIST_HEAD_INITIALIZER(vfio_address_spaces);
> >>
> >>
> >
>
>