[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 01/12] vt82c686: avoid out-of-bounds read
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 01/12] vt82c686: avoid out-of-bounds read |
Date: |
Thu, 15 Jan 2015 11:30:39 +0300 |
From: Paolo Bonzini <address@hidden>
superio_ioport_readb can read the 256th element of the array.
Coverity reports an out-of-bounds write in superio_ioport_writeb,
but it does not show the corresponding out-of-bounds read
because it cannot prove that it can happen. Fix the root
cause of the problem (zhanghailang's patch instead fixes
the logic in superio_ioport_writeb).
Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: zhanghailiang <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
Cc: address@hidden
---
hw/isa/vt82c686.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c
index 223b947..2f53bf8 100644
--- a/hw/isa/vt82c686.c
+++ b/hw/isa/vt82c686.c
@@ -36,7 +36,7 @@
typedef struct SuperIOConfig
{
- uint8_t config[0xff];
+ uint8_t config[0x100];
uint8_t index;
uint8_t data;
} SuperIOConfig;
--
2.1.4
- [Qemu-trivial] [PULL 00/12] Trivial patches for 2015-01-15, Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 07/12] misc: Fix new typos in comments, Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 10/12] Makefile: Remove config.status and common.env during 'make distclean', Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 08/12] Do not hang on full PTY, Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 04/12] migration/qemu-file.c: Don't shift left into sign bit, Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 05/12] target-tricore: Fix new typos, Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 03/12] translate-all: Mark map_exec() with the 'unused' attribute, Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 01/12] vt82c686: avoid out-of-bounds read,
Michael Tokarev <=
- [Qemu-trivial] [PULL 06/12] target-arm: Fix typo in comment (seperately -> separately), Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 12/12] vl.c: fix some alignment issues, Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 09/12] target-openrisc: bugfix for dec_sys to decode instructions correctly, Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 02/12] tests/hd-geo-test.c: Remove unused test_image variable, Michael Tokarev, 2015/01/15
- [Qemu-trivial] [PULL 11/12] blizzard: do not depend on VGA internals, Michael Tokarev, 2015/01/15
- Re: [Qemu-trivial] [Qemu-devel] [PULL 00/12] Trivial patches for 2015-01-15, Peter Maydell, 2015/01/15