[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH 1/3] rng-random: NULL check not needed before
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-trivial] [PATCH 1/3] rng-random: NULL check not needed before g_free() |
Date: |
Mon, 9 Jun 2014 16:04:26 -0400 |
On Fri, 30 May 2014 17:02:18 -0300
Eduardo Habkost <address@hidden> wrote:
> g_free() is NULL-safe.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
This one should to go through qemu-trivial (CCed).
> ---
> Cc: Anthony Liguori <address@hidden>
> Cc: Luiz Capitulino <address@hidden>
> ---
> backends/rng-random.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/backends/rng-random.c b/backends/rng-random.c
> index 136499d..601d9dc 100644
> --- a/backends/rng-random.c
> +++ b/backends/rng-random.c
> @@ -106,10 +106,7 @@ static void rng_random_set_filename(Object *obj, const
> char *filename,
> return;
> }
>
> - if (s->filename) {
> - g_free(s->filename);
> - }
> -
> + g_free(s->filename);
> s->filename = g_strdup(filename);
> }
>
- Re: [Qemu-trivial] [PATCH 1/3] rng-random: NULL check not needed before g_free(),
Luiz Capitulino <=