[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v3] serial-pci: Set prog interface field of pc
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-trivial] [PATCH v3] serial-pci: Set prog interface field of pci config to 16550 compatible |
Date: |
Thu, 15 May 2014 08:42:17 +0200 |
On Do, 2014-02-27 at 02:05 +0100, BALATON Zoltan wrote:
^^^^^^^^^^
Looks like your clock is _way_ off.
> + if (!pci->compat) {
> + pci->dev.config[PCI_CLASS_PROG] = 0x02; /* 16550 compatible */
> + }
> static Property serial_pci_properties[] = {
> DEFINE_PROP_CHR("chardev", PCISerialState, state.chr),
> + DEFINE_PROP_UINT8("compat", PCISerialState, compat, 0),
> DEFINE_PROP_END_OF_LIST(),
> };
> + {\
> + .driver = "pci-serial",\
> + .property = "compat",\
> + .value = stringify(1),\
> + },\
Reviewed-by: Gerd Hoffmann <address@hidden>
mst, do you take that through the pci tree?
cheers,
Gerd