[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] Makefile.target: use $(INSTALL_PROG) for inst
From: |
Fam Zheng |
Subject: |
Re: [Qemu-trivial] [PATCH] Makefile.target: use $(INSTALL_PROG) for installing, not $(INSTALL) |
Date: |
Thu, 8 May 2014 20:41:08 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, 05/08 15:02, Michael Tokarev wrote:
> $(INSTALL_PROG) is evaluated to libtool if using libtool, while
> $(INSTALL) is not. Use $(INSTALL_PROG) so that libtool is used
> with target too when necessary. This allows, for example, to
> link qemu with shared libcacard.
>
> Signed-off-by: Michael Tokarev <address@hidden>
> Cc: Fam Zheng <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Alon Levy <address@hidden>
> Cc: address@hidden
Reviewed-by: Fam Zheng <address@hidden>
> --
> This is done on top of previous patch (using $(STRIP)), but it can
> be used by its own.
> ---
> Makefile.target | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index 8de8b12..3b75ade 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -194,7 +194,7 @@ endif
>
> install: all
> ifneq ($(PROGS),)
> - $(INSTALL) -m 755 $(PROGS) "$(DESTDIR)$(bindir)"
> + $(INSTALL_PROG) $(PROGS) "$(DESTDIR)$(bindir)"
> ifneq ($(STRIP),)
> $(STRIP) $(PROGS:%="$(DESTDIR)$(bindir)/%")
> endif
> --
> 1.7.10.4
>