[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-char.c: fix waiting for tel
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-char.c: fix waiting for telnet connection message |
Date: |
Mon, 11 Mar 2013 10:28:29 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Igor Mitsyanko <address@hidden> writes:
> Current colon position in "waiting for telnet connection" message template
> produces messages like:
> QEMU waiting for connection on: telnet::127.0.0.16666,server
>
> After moving a colon to the right, we will get a correct messages like:
> QEMU waiting for connection on: telnet:127.0.0.1:6666,server
>
> Signed-off-by: Igor Mitsyanko <address@hidden>
> ---
> qemu-char.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 36295b1..789ee35 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -2476,7 +2476,7 @@ static CharDriverState *qemu_chr_open_socket_fd(int fd,
> bool do_nodelay,
> s->do_nodelay = do_nodelay;
> getnameinfo((struct sockaddr *) &ss, ss_len, host, sizeof(host),
> serv, sizeof(serv), NI_NUMERICHOST | NI_NUMERICSERV);
> - snprintf(chr->filename, 256, "%s:%s:%s%s%s%s",
> + snprintf(chr->filename, 256, "%s:%s%s%s:%s%s",
> is_telnet ? "telnet" : "tcp",
> left, host, right, serv,
> is_listen ? ",server" : "");
Broken in commit f6bd5d6e. Nice to have that information in the commit
message, but not worth a respin.
Reviewed-by: Markus Armbruster <address@hidden>