[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH 1/3] configure: fix detection for cURL libs wh
From: |
Yann E. MORIN |
Subject: |
Re: [Qemu-trivial] [PATCH 1/3] configure: fix detection for cURL libs when static linking |
Date: |
Mon, 27 Aug 2012 19:21:28 +0200 |
User-agent: |
KMail/1.13.5 (Linux/3.5.2-treguer; KDE/4.4.5; x86_64; ; ) |
Stefan, All,
On Friday 24 August 2012 13:02:24 Stefan Hajnoczi wrote:
> On Mon, Aug 20, 2012 at 11:39:07PM +0200, Yann E. MORIN wrote:
> > Currently, configure uses the same code-path to check for cURL libraries,
> > whether we are doing a static or dynamic build.
> >
> > Fix that by pasing the proper arguments: '--static-libs' for curl-config
> > and '--static --libs' for pkg-config when a static build is attempted.
> >
> > Signed-off-by: "Yann E. MORIN" <address@hidden>
> > ---
> > configure | 8 +++++++-
> > 1 files changed, 7 insertions(+), 1 deletions(-)
>
> Can you set pkgconfig --static --libs in one place so the if [ "$static"
> = "yes" ] code isn't duplicated several times? (This is a general
> question about the entire patch series.)
Yes, it perfectly makes sense; I'll work on this. Thank you!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'