[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting
From: |
Peter Maydell |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values correctly |
Date: |
Tue, 27 Mar 2012 16:43:35 +0100 |
This patch is simple enough (and m68k unmaintained enough)
that it could reasonably go through qemu-trivial I think.
-- PMM
On 27 March 2012 16:07, Meador Inge <address@hidden> wrote:
> Ping.
>
> On 02/24/2012 04:53 PM, Andreas Färber wrote:
>> Am 24.02.2012 23:18, schrieb Meador Inge:
>>> Fixing a simple typo, s/errno/err/, that caused
>>> the error status from GDB semihosted system calls
>>> to be returned incorrectly.
>>>
>>> Signed-off-by: Meador Inge <address@hidden>
>>
>> Nice catch!
>>
>> Reviewed-by: Andreas Färber <address@hidden>
>>
>> Andreas
>>
>>> ---
>>> m68k-semi.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/m68k-semi.c b/m68k-semi.c
>>> index bab01ee..6d60ced 100644
>>> --- a/m68k-semi.c
>>> +++ b/m68k-semi.c
>>> @@ -150,7 +150,7 @@ static void m68k_semi_cb(CPUState *env, target_ulong
>>> ret, target_ulong err)
>>> }
>>> /* FIXME - handle put_user() failure */
>>> put_user_u32(ret, args);
>>> - put_user_u32(errno, args + 4);
>>> + put_user_u32(err, args + 4);
>>> }
>>>
>>> #define ARG(n) \
>>
>
>
> --
> Meador Inge
> CodeSourcery / Mentor Embedded
> http://www.mentor.com/embedded-software
>
- Re: [Qemu-trivial] [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values correctly,
Peter Maydell <=