[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] target/m68k: Handle EXCP_SEMIHOSTING for m68k class CPU
From: |
Jiaxun Yang |
Subject: |
Re: [PATCH v2] target/m68k: Handle EXCP_SEMIHOSTING for m68k class CPU |
Date: |
Sun, 29 Dec 2024 15:40:17 +0000 |
在2024年12月29日十二月 下午3:15,BALATON Zoltan写道:
[...]
>
> Also why use switch for a single case? Why not write
>
> if (!is_hw && cs->exception_index == EXCP_SEMIHOSTING)
Mostly for clarity and matching the style above, see:
if (!is_hw) {
switch (cs->exception_index) {
case EXCP_RTE:
/* Return from an exception. */
m68k_rte(env);
return;
}
}
Thanks
>
> instead?
>
[...]
>>
--
- Jiaxun