Re: [PATCH] dma-helpers: Fix iovec alignment

[Peter Xu]

On Sat, Dec 21, 2024 at 12:07:05AM +0300, Michael Tokarev wrote:
> 11.08.2024 20:47, Michael Tokarev пишет:
> > 12.04.2024 18:25, Eric Blake wrote:
> > > On Fri, Apr 12, 2024 at 10:06:17AM +0200, Stefan Fritsch wrote:
> > > > Commit 99868af3d0 changed the hardcoded constant BDRV_SECTOR_SIZE to a
> > > > dynamic field 'align' but introduced a bug. qemu_iovec_discard_back()
> > > > is now passed the wanted iov length instead of the actually required
> > > > amount that should be removed from the end of the iov.
> > > > 
> > > > The bug can likely only be hit in uncommon configurations, e.g. with
> > > > icount enabled or when reading from disk directly to device memory.
> > 
> > Hi!
> > 
> > Has this change (proposed for 9.0) been forgotten or is it not needed
> > anymore?
> 
> Ping #2?

Hello, Michael,

Looks like we didn't reach a consensus on merging it?  See:

https://lore.kernel.org/qemu-devel/CAFn=p-Y1sAXfzx6cWEgeYyMyG3yn1vEpDmV2K8qWtLx4otm4tw@mail.gmail.com/

Thanks,

-- 
Peter Xu