Re: [PATCH v2] tcg: Reset free_temps before tcg_optimize

[Philippe Mathieu-Daudé]

On 10/12/24 15:52, Richard Henderson wrote:
> When allocating new temps during tcg_optmize, do not re-use
> any EBB temps that were used within the TB.  We do not have
> any idea what span of the TB in which the temp was live.
>
> Introduce tcg_temp_ebb_reset_freed and use before tcg_optimize,
> as well as replacing the equivalent in plugin_gen_inject and
> tcg_func_start.
>
> Cc: qemu-stable@nongnu.org
> Fixes: fb04ab7ddd8 ("tcg/optimize: Lower TCG_COND_TST{EQ,NE} if unsupported")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2711
> Reported-by: wannacu <wannacu2049@gmail.com>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   include/tcg/tcg-temp-internal.h | 6 ++++++
>   accel/tcg/plugin-gen.c          | 2 +-
>   tcg/tcg.c                       | 5 ++++-
>   3 files changed, 11 insertions(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>